[
https://issues.apache.org/jira/browse/SLING-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899498#comment-17899498
]
Scott Yuan commented on SLING-12493:
------------------------------------
Hello [~rombert] ,
Yes, I can assist with updating this module and cleaning up the test cases.
After a quick review of the existing test cases and dependencies, I plan to
provide 2–3 pull requests to progressively address this work. Below is a rough
plan for the pull request sequence:
# Upgrade Mockito to version 5 and update parent dependencies to a more recent
release.
# Migrate test cases to JUnit 5.
# Decouple Oak usage in the test cases by using MOCK_JCR or similar
alternatives.
Step 3 may require additional time and consideration, depending on the
readiness of mock tools for Java 17/21.
Best regards,
[~yuansc]
> Apache Sling Scripting JavaScript 3.1.4+ test failed with Java 17 and Java 21
> -----------------------------------------------------------------------------
>
> Key: SLING-12493
> URL: https://issues.apache.org/jira/browse/SLING-12493
> Project: Sling
> Issue Type: Improvement
> Components: Scripting
> Affects Versions: Scripting JavaScript 3.1.4
> Environment: Windows, MacOS, Linux
> Reporter: Scott Yuan
> Priority: Minor
> Original Estimate: 15h
> Remaining Estimate: 15h
>
> With the latest Apache Sling Scripting JavaScript 3.1.4+ release, attempts to
> build the code using Java 17 and Java 21 failed due to incompatible unit
> tests.
> The release build observed in [this CI
> job|https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-scripting-javascript/job/master/]
> confirmed that this issue caused multiple build failures.
> Modernizing the tests would greatly improve the build process, making it
> cleaner and more reliable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
