rombert commented on PR #18:
URL: 
https://github.com/apache/sling-org-apache-sling-commons-log/pull/18#issuecomment-2580646446

   @enapps-enorman - the changes look very good to me. Happy to see that we're 
not embedding any bundles anymore, which will make upgrades much easier and the 
need to release new versions of this bundle much smaller.
   
   I think the version bump of the exported 
`org.apache.sling.commons.log.logback` is fine.
   
   I am still thinking of the SPIFly requirement and would like to avoid it. I 
think for scenarions like the sling-mini it would be very good to keep the 
bundle requirements low. I am not going to oppose merging as-is but will write 
an email to dev@sling to give everyone the change to comment or - ideally - to 
come up with a way of avoiding adding this requirement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to