On Fri, 2025-01-10 at 08:54 +0100, Carsten Ziegeler wrote: > On 09.01.2025 17:25, Robert Munteanu wrote: > > > > I took a brief look at the API bundleonly. Having no breaking > > changes > > is very encouraging. There is of course some duplication, e.g. > > between > > SlingSafeMethodsServlet and SlingJakartaSafeMethodsServlet. > > Duplication > > is not the worst thing to happen, but I was wondering if you have > > any > > thoughts about making sure the implementations stay consistent. For > > instance, a generic bugfix should be applicable to both Jakarta and > > Servlet API variants. > > > I don't see any good way of avoiding the duplication. So if we have > to > fix something in both, this will hopefully be caught in the PR > review. > I also deprecated all API based on javax.servlet - that doesn't help > with bug fixes, but at least for new features we should only add it > to > the Jakarta servlet based API.
Understood. I Was thinking whether the Eclipse transformer [1] can help here with testing by transforming our existing javax.servlet tests into jakarta.servlet ones but it's unaware of our Jakarta API extensions. With parallel APIs it can't help with the code of our users either. Maybe someone comes us with a smart idea about how to test both implementations. Thanks, Robert [1]: https://github.com/eclipse-transformer/transformer
