[ 
https://issues.apache.org/jira/browse/SLING-12440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912815#comment-17912815
 ] 

Joerg Hoh edited comment on SLING-12440 at 1/14/25 10:02 AM:
-------------------------------------------------------------

[~ptos] org.apache.sling.sitemap.builder.Extension is a marker interface, and 
for that reason I don't understand why "the implementation" (an implementation 
of that interface?) would not need to to extend this interface.
In my opinion custom code just needs to implement this interface, there is no 
need to extend it.

(But yes, converting it to a @ConsumerType is necessary.)


was (Author: joerghoh):
[~ptos] org.apache.sling.sitemap.builder.Extension is a marker interface, and 
for that reason I don't understand why an implementation (??) would not need to 
to extend this interface.
In my opinion custom code just needs to implement this interface, there is no 
need to extend it.

(But yes, converting it to a @ConsumerType is necessary.)

> Extension incorrectly annotated with @ProviderType
> --------------------------------------------------
>
>                 Key: SLING-12440
>                 URL: https://issues.apache.org/jira/browse/SLING-12440
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Peter Tos
>            Priority: Major
>              Labels: sitemaps
>
> org.apache.sling.sitemap.builder.Extension is annotated with @ProviderType, 
> but the implementation requires the consumer to extend this interface. This 
> should be changed to @ConsumerType.
>  
> https://github.com/apache/sling-org-apache-sling-sitemap/blob/master/src/main/java/org/apache/sling/sitemap/builder/Extension.java#L29



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to