anchela commented on code in PR #57:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/57#discussion_r1944456085
##########
pom.xml:
##########
@@ -37,7 +37,7 @@
<properties>
<jackrabbit.version>2.18.2</jackrabbit.version>
- <oak.version>1.22.10</oak.version>
+ <oak.version>1.44.0</oak.version>
Review Comment:
is there a reason for not using the latest oak version? i believe this would
be 1.74.0
note: once we move from oak 1.22.x (which comes from the corresponding
branch) to a newer version of oak that is cut from trunk, the bundle will no
longer be compatible with code that runs on the 1.22-branch of oak.
we made breaking changes
- for modularization
- to comply with new java versions that had deprecated security classes
removed and
- in order to update guava
i am not sure if and how big of an issue this could be. but wanted to call
it out. updating to a newer version of oak makes sense from a pure technical
pov and we can leverage performance optimizations added to the api like e.g.
privilegecollection and additional methods to retrieve the parent instead of
traversing again from the root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
