I have provided a PR for a better interface:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/71

Regards,
Christian

On Tue, 11 Mar 2025 at 14:52, Timothee Maret <tma...@apache.org> wrote:

> Hi Christian,
>
> Thanks for your vote !
>
> The interface implementation builds File Vault serializers and thus needs
> to pass the parameters.
>
> The provider is needed to implement SLING-12704.
>
> Does that clear your concerns ? If not, could you please propose a
> constructive alternative ?
>
> Regards,
>
> Timothée
>
> Le mar. 11 mars 2025 à 14:33, Christian Schneider <ch...@die-schneider.net
> >
> a écrit :
>
> > -1
> >
> > The new DistributionContentSerializerProvider interface has far too many
> > parameters in the build method.
> > Also I do not understand why it is needed.
> >
> > We should first discuss and agree on a design before this API change is
> > made.
> >
> > Christian
> >
> > On Mon, 10 Mar 2025 at 15:14, Timothee Maret <tma...@apache.org> wrote:
> >
> > > Hi,
> > >
> > > We solved 1 issues in this release:
> > > https://issues.apache.org/jira/projects/SLING/versions/12351425
> > >
> > > Staging repository:
> > >
> https://repository.apache.org/content/repositories/orgapachesling-2937/
> > >
> > > You can use this UNIX script to download the release and verify the
> > > signatures:
> > >
> > >
> >
> https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
> > >
> > > Usage:
> > > sh check_staged_release.sh 2937 /tmp/sling-staging
> > >
> > > Please vote to approve this release:
> > >
> > >   [ ] +1 Approve the release
> > >   [ ]  0 Don't care
> > >   [ ] -1 Don't release, because ...
> > >
> > > This majority vote is open for at least 72 hours.
> > >
> >
> >
> > --
> > --
> > Christian Schneider
> > http://www.liquid-reality.de
> >
> > Computer Scientist
> > http://www.adobe.com
> >
>


-- 
-- 
Christian Schneider
http://www.liquid-reality.de

Computer Scientist
http://www.adobe.com

Reply via email to