[
https://issues.apache.org/jira/browse/SLING-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156249#comment-13156249
]
Felix Meschberger commented on SLING-2299:
------------------------------------------
Same for RedirectOnLoginErrorTest: fixed in Rev. 1205563
> Consolidate constants and utility methods
> -----------------------------------------
>
> Key: SLING-2299
> URL: https://issues.apache.org/jira/browse/SLING-2299
> Project: Sling
> Issue Type: Improvement
> Components: Authentication
> Affects Versions: Auth Core 1.0.6
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: Auth Core 1.1.0
>
>
> Currently we have constants spread around class in the Auth Core bundle and
> we have a number of utility methods in the AbstractAuthenticationHandler.
> There is even a duplicate isBrowserRequest method in the SlingAuthenticator
> class (wrongly implemented using the Accept header) and the AuthUtil class.
> We should consolidate the utility methods into the AuthUtil class and the
> constants into the AuthConstants class.
> This also helps with future evolution: Whenever we add an exported constant
> or utility method, we have to increase the minor version of the exported
> package. If this happens on the spi package this would cause all
> implementations to become incompatible, even though they are not. By having
> these methods in a separate exported package which containing a single
> interface not intended to be implemented outside of the auth core bundle, we
> can increase the minor version of this package without breaking any clients.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
