joerghoh commented on code in PR #58:
URL:
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/58#discussion_r2062605968
##########
src/main/java/org/apache/sling/servlets/resolver/internal/SlingServletResolver.java:
##########
@@ -460,6 +469,16 @@ private Resource getErrorResource(final
SlingHttpServletRequest request) {
return res;
}
+ /** @return true if the given Resource is hidden by our
resourceHidingPredicate */
+ private boolean isHidden(Resource r) {
Review Comment:
I would explicitly mention that this method requires a non-null parameter
(and that for this reason null-checks are missing).
```suggestion
private boolean isHidden(@NotNull Resource r) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
