joerghoh commented on code in PR #44:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-resource/pull/44#discussion_r2066349836
##########
src/main/java/org/apache/sling/jcr/resource/internal/helper/JcrPropertyMapCacheEntry.java:
##########
@@ -132,7 +132,7 @@ private static void failIfCannotStore(final @NotNull Object
value, final @NotNul
final ByteArrayInputStream bais = new
ByteArrayInputStream(baos.toByteArray());
value =
session.getValueFactory().createValue(session.getValueFactory().createBinary(bais));
} catch (IOException ioe) {
- // we ignore this here and return null
+ throw new RepositoryException("Cannot serialize object", ioe);
Review Comment:
It would make sense to also log the node path and the type of the object in
this exception, as it can help to further debug the issue in more detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
