raducotescu commented on code in PR #62:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/62#discussion_r2108623024
##########
src/main/java/org/apache/sling/engine/impl/filter/ErrorFilterChain.java:
##########
@@ -118,6 +121,10 @@ public void doFilter(final ServletRequest request, final
ServletResponse respons
return;
}
// reset the response to clear headers and body
+ if (response instanceof SlingHttpServletResponseImpl) {
+ final DispatchingInfo dispatchInfo = new
DispatchingInfo(DispatcherType.ERROR);
+ ((SlingHttpServletResponseImpl)
response).getRequestData().setDispatchingInfo(dispatchInfo);
+ }
Review Comment:
Yes, we never needed to until now and hopefully we won't need to do it in
other places either. That being said, I think we need to reuse that object
rather than creating a new one and losing all that information – we might find
other uses for it inside this bundle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
