[ 
https://issues.apache.org/jira/browse/SLING-12874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011917#comment-18011917
 ] 

Eric Norman commented on SLING-12874:
-------------------------------------

Hi Robert,
{quote}Doesn't the compatibility approach that we have for Jakarta/Javax remove 
the need to move all downstream modules to Jakarta?
{quote}
The problem with that theory is that SlingHttpServletRequest has been marked as 
deprecated in sling.api version 3.0,  If you migrate to that version in your 
project dependencies, then all the places where sling models are adapting from 
a SlingHttpServletRequest or injecting a 
SlingHttpServletRequest/SlingHttpServletResponse into the sling model object 
get flagged as using a deprecated api.

I wasn't willing to ignore the hundreds of new warnings about using deprecated 
apis in my codebase. 

If you have any concerns about the proposed changes in the PR, then please 
review and provide that feedback there.

 

> migrate ModelFactory to Sling API 3.x and Jakarta Servlet
> ---------------------------------------------------------
>
>                 Key: SLING-12874
>                 URL: https://issues.apache.org/jira/browse/SLING-12874
>             Project: Sling
>          Issue Type: Sub-task
>            Reporter: Eric Norman
>            Assignee: Eric Norman
>            Priority: Major
>             Fix For: Models API 2.0.0
>
>
> bump bundle major version to 2.0.0
> bump minimum java version to 17
> bump sling.api dependency to 3.0.0
> clone the ModelFactory methods that use SlingHttpServletRequest parameters to 
> use SlingJakartaHttpServletRequest instead
> deprecate the ModelFactory methods that used SlingHttpServletRequest



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to