Konrad Windszus created SLING-12878:
---------------------------------------

             Summary: Converter potentially removes still relevant filter 
entries of converted packages
                 Key: SLING-12878
                 URL: https://issues.apache.org/jira/browse/SLING-12878
             Project: Sling
          Issue Type: Bug
          Components: Content-Package to Feature Model Converter
    Affects Versions: Content-Package to Feature Model Converter 1.3.10
            Reporter: Konrad Windszus


The logic in 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/d75256c7ed76281f411f4275ea2afe79bf395cbc/src/main/java/org/apache/sling/feature/cpconverter/vltpkg/WorkspaceFilterBuilder.java#L77-L84
 removes filter entries from the original package filter too agressively for 
the edge case where some subnodes below a common ancestor have been removed 
(like OSGi configuration) but other subnodes are still relevant to be kept in 
the package.

In that case the method 
[{{coversFilteredPath}}|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/d75256c7ed76281f411f4275ea2afe79bf395cbc/src/main/java/org/apache/sling/feature/cpconverter/vltpkg/WorkspaceFilterBuilder.java#L106]
 returns {{true}} which leads to the whole filter entry not being part of the 
converted package.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to