[
https://issues.apache.org/jira/browse/SLING-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165121#comment-13165121
]
Carsten Ziegeler commented on SLING-2166:
-----------------------------------------
Yes, I think adding the config options to the Main Servlet makes sense or
creating a new file upload handler component which is used by the main servlet.
I think we should use the FileCleaningTracker and not rely on the app to
cleanup. We could also make the dispose method available in addition, but as
long as there is no real need for that, we shouldn't do it :)
> Make file upload logic configurable
> -----------------------------------
>
> Key: SLING-2166
> URL: https://issues.apache.org/jira/browse/SLING-2166
> Project: Sling
> Issue Type: Improvement
> Components: Engine
> Reporter: Chetan Mehrotra
> Priority: Minor
>
> The current file upload logic in Sling Engine (as present in ParameterSupport
> [1] class) relies on Common Fileupload. This logic can be enhanced to use
> some features provided by the Common Fileupload library
> - Allow location of folder where temporary files are created configurable.
> This can be done by specifying the repository in the DiskFileItemFactory. So
> for Sling we can set to a folder under launchpad and better manage it
> - Enable the FileCleaningTracker such that any temporary file that gets
> created also get deleted.
> - Allow specifying the maximum file size that can be uploaded
> - Update the version of file upload library
> Further the FileCleaningTracker can be exposed as a service and used by other
> components
> [1]
> http://svn.apache.org/repos/asf/sling/trunk/bundles/engine/src/main/java/org/apache/sling/engine/impl/parameters/ParameterSupport.java
> [2]
> http://svn.apache.org/repos/asf/commons/proper/io/trunk/src/main/java/org/apache/commons/io/FileCleaningTracker.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
