joerghoh commented on code in PR #197:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/197#discussion_r2297919321
##########
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##########
@@ -485,6 +516,8 @@ public void onChange(final List<ResourceChange> changes) {
private boolean handleResourceChange(
ResourceChange.ChangeType type,
String path,
+ boolean forAlias,
+ boolean forVanityPath,
Review Comment:
I am not happy with the signature of this method anymore, it has now 6
parameters, and we need to pass on all parameters to the respective
``(remove|add|update)Resource`` methods.
I think we should create a very simple record-style class as a container as
a subclass (maybe ```ResourceChangeContext```).
That could simplify the code quite a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
