enapps-enorman commented on code in PR #51:
URL: https://github.com/apache/sling-parent/pull/51#discussion_r2384400320
##########
sling-parent/pom.xml:
##########
@@ -128,7 +129,17 @@
<dependency>
<groupId>javax.servlet</groupId>
<artifactId>javax.servlet-api</artifactId>
- <version>3.1.0</version>
+ <version>4.0.1</version>
+ </dependency>
+ <dependency>
+ <groupId>jakarta.servlet</groupId>
+ <artifactId>jakarta.servlet-api</artifactId>
+ <version>6.1.0</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>org.apache.felix.http.wrappers</artifactId>
Review Comment:
@kwin Thanks for reviewing. I'm not certain how common usage of the felix
http wrappers will be in practice. I think the main reason I put that there
was that it provides interoperability between javax.servlet-api and
jakarta.servlet-api that we declare in the pom and I wanted to make sure that
any places that need this wrapper functionality uses the version that is
compatible with the jakarta.servlet-api release being used.
For example:
- org.apache.felix.http.wrappers:1.1.10 is for jakarta.servlet-api:6.0.0
- org.apache.felix.http.wrappers:6.1.0 is for jakarta.servlet-api:6.1.0
Would a note that says to keep the jakarta.servlet-api and
org.apache.felix.http.wrappers versions in sync resolve your concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
