enapps-enorman commented on code in PR #58:
URL: https://github.com/apache/sling-parent/pull/58#discussion_r2433870989


##########
sling-parent/pom.xml:
##########
@@ -292,7 +292,7 @@
                 <plugin>
                     <groupId>com.diffplug.spotless</groupId>
                     <artifactId>spotless-maven-plugin</artifactId>
-                    <version>2.44.0.BETA4</version>
+                    <version>3.0.0</version>

Review Comment:
   @kwin Per https://github.com/diffplug/spotless/releases the 2.71.0 version 
is the default for the 3.0.0 release.  So would it be better to set it to a 
specific version or remove the configuration and use the default value?
   
   Update: I see comment in the pom that says the orders of used formatters are 
important, so perhaps we have to specify a version to get the order right?  In 
that case, any objection to 2.80.0 instead of 2.71.0?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to