rombert commented on code in PR #46:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/46#discussion_r2410793780
##########
bnd.bnd:
##########
@@ -8,18 +8,13 @@ Import-Package: \
javax.servlet;resolution:=optional,\
javax.annotation;version="[0.0,2)",\
*
-Export-Package: \
- org.apache.sling.event.jobs,\
- org.apache.sling.event.jobs.consumer,\
- org.apache.sling.event.jobs.jmx
-conditionalpackage: \
org.apache.jackrabbit.util,\
org.apache.sling.commons.osgi,\
org.apache.sling.event.api
Review Comment:
Do you also need to remove this api reference?
##########
pom.xml:
##########
@@ -29,10 +29,10 @@
</parent>
<artifactId>org.apache.sling.event</artifactId>
- <version>4.3.19-SNAPSHOT</version>
+ <version>4.4.0-SNAPSHOT</version>
- <name>Apache Sling Event</name>
- <description>Support for eventing.</description>
+ <name>Apache Sling Event Impl</name>
Review Comment:
I would suggest also renaming the Jira release to 'Event Impl' to make this
work with the Commiter CLI out of the box.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
