Also, an alternate proposed PR is at https://github.com/apache/sling-parent/pull/58 that implements what I originally proposed if you prefer that instead.
Regards, Eric On Tue, Oct 14, 2025 at 3:41 PM Eric Norman <[email protected]> wrote: > Thank you all for your feedback. Given Robert's feedback that there are > still some places using and testing with java 11, I have proposed a pull > request that should solve the issue while retaining support for java 11 for > now. The 3.x version of spotless would only be used for java 17 or later. > > The proposed PR is at: https://github.com/apache/sling-parent/pull/57 and > I have requested a review from all the people who voted here. > > Regards, > Eric > > On Fri, Oct 10, 2025 at 3:43 AM Robert Munteanu <[email protected]> > wrote: > >> On Wed, 2025-10-08 at 16:31 -0700, Eric Norman wrote: >> > So my proposal is to bump the minimalJavaBuildVersion to 17 in sling- >> > parent >> > to unify it in both places so we are ready to use third-party >> > libraries >> > that now require it. >> >> -0 >> >> I have a module that uses sling (parent) 62 and still builds for Java >> 11. >> >> https://github.com/apache/sling-org-apache-sling-connection-timeout-agent >> >> It's a Java agent and testing on multiple JVMs is desired because it >> can be sensitive to low-level impl changes , see [1] for an example. >> >> But we can just delay the parent pom upgrade for that module until we >> decide to drop support for Java 11. >> >> If we drop Java 11 support it might be a good idea to also adjust the >> default build JDKs are remove Java 11, see [2] and [3]. >> >> Thanks, >> Robert >> >> [1]: >> >> https://github.com/apache/sling-org-apache-sling-connection-timeout-agent/pull/9 >> [2]: >> >> https://github.com/apache/sling-tooling-jenkins/blob/a9c7d5f999acb07c050e1ac0d824196ab3fcc1fc/vars/slingOsgiBundleBuild.groovy#L20 >> [3]: >> https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor >> >
