[ 
https://issues.apache.org/jira/browse/SLING-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18031420#comment-18031420
 ] 

Robert Munteanu commented on SLING-10606:
-----------------------------------------

Thanks for picking this up [~enorman]. The changes all look good to me, I only 
had a minor implementation comment in the pr for SLING-12970.

> Default login page should not reference content from the starter.content 
> module
> -------------------------------------------------------------------------------
>
>                 Key: SLING-10606
>                 URL: https://issues.apache.org/jira/browse/SLING-10606
>             Project: Sling
>          Issue Type: Improvement
>          Components: Authentication, Starter
>            Reporter: Robert Munteanu
>            Assignee: Eric Norman
>            Priority: Major
>             Fix For: Starter Content 2.0.2, Form Based Authentication 2.0.0
>
>         Attachments: login-form-without-starter-content.png, 
> resources-not-found-without-starter-content.png
>
>
> The default login form references images and styles from the starter.content. 
> We should avoid that, since the default login form can be deployed in other 
> scenarios as well. Instead, we should:
> - provide a standalone login page for the o.a.s.auth.form bundle
> - move the current login form to o.a.s.starter.content bundle
> The intent is to have a good-looking form for the starter content but also 
> one that does not look broken for auth.form.
> We should also add an HTML comment to the default login form pointing to 
> customisation possibilites.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to