rubnig commented on code in PR #71:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/71#discussion_r2613682015
##########
src/main/java/org/apache/sling/api/uri/SlingUriBuilder.java:
##########
@@ -227,8 +227,8 @@ public static SlingUriBuilder createFrom(@NotNull URI uri,
@Nullable ResourceRes
String path = uri.getRawPath();
boolean pathExists = isNotBlank(path);
String uriQuery = uri.getRawQuery();
- boolean schemeSpecificRelevant = !pathExists && uriQuery == null;
String uriHost = uri.getHost();
+ boolean schemeSpecificRelevant = !pathExists && uriQuery == null &&
uriHost == null;
Review Comment:
Not sure if `sling.apache.org` should resolve to just `sling.apache.org` (if
no scheme is provided). That is why I didn't resort to any other logic for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
