rombert commented on code in PR #55:
URL:
https://github.com/apache/sling-org-apache-sling-testing-clients/pull/55#discussion_r2630761963
##########
pom.xml:
##########
@@ -171,13 +169,13 @@
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
- <version>2.15.1</version>
+ <version>2.20.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-simple</artifactId>
- <version>1.7.36</version>
+ <version>${slf4j.version}</version>
Review Comment:
This artifact is already managed in the parent pom, so you can remove the
`<version/>` tag. I think it works but it's a bit confusing since the property
is defined in the parent pom. You actually did that for slf4j-api in the same
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
