bkkothari2255 commented on PR #69: URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/69#issuecomment-3737023045
> This doesn't look converted to junit5 to me. The "import org.junit._" lines are still junit4 and would need to be changed to the junit5 equivalent (i.e. "import org.junit.jupiter.api._"). > > Also I think you need at least the junit-jupiter-engine dependency in the pom to run junit5 tests. And probably the mockito junit runner needs some changes to be compatible with junit5. Thanks for catching that—you are absolutely right. I focused on the assertion logic and missed the full infrastructure updates in the previous commit. I will push it shortly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
