stefan-egli commented on code in PR #52:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/52#discussion_r2694020374
##########
src/main/java/org/apache/sling/event/impl/jobs/config/JobManagerConfiguration.java:
##########
@@ -248,9 +248,7 @@ protected void unbindJobProcessingEnabledCondition(final
Condition condition) {
if (this.jobProcessingEnabledCondition == condition) {
this.jobProcessingEnabledCondition = null;
logger.info("Job processing readiness condition has been removed -
jobs will not be processed");
- // Signal jobs to stop before notifying listeners
stopProcessing();
- notifyListeners();
Review Comment:
before the first `TOPOLOGY_INIT` though `this.topologyCapabilities` would be
`null`, so `stopProcessing()` wouldn't notify the listeners - but it does in
this case. are we sure we don't need to notify in case we haven't gotten the
`TOPOLOGY_INIT` yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
