joerghoh commented on code in PR #70: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/70#discussion_r2769172290
########## src/test/java/org/apache/sling/engine/impl/SlingMainServletTest.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.sling.engine.impl; + +import java.lang.reflect.Field; + +import jakarta.servlet.ServletException; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mock; +import org.mockito.MockitoAnnotations; + +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +public class SlingMainServletTest { + + @Mock + private HttpServletRequest request; + + @Mock + private HttpServletResponse response; + + private SlingMainServlet servlet; + + @Before + public void setUp() { + MockitoAnnotations.openMocks(this); + servlet = new SlingMainServlet(); + setAllowTrace(false); Review Comment: Do you see a way to inject this the proper way? I know that it's possible to configure this value via OSGI, so would it be possible to configure it the same (or very similar) way here as well? I would resort to use introspection only if there's no other way to achieve it (as you are now relying on implementation details of that class, especially on the names of private variables). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
