[
https://issues.apache.org/jira/browse/SLING-13053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18062507#comment-18062507
]
Carsten Ziegeler commented on SLING-13053:
------------------------------------------
Concurrency review finding related to notifyListeners():
In JobManagerConfiguration.notifyListeners(), listener callbacks are invoked
inside synchronized(this.listeners). If any listener's configurationChanged()
tried to add/remove a listener, it would deadlock. Proposed fix: copy the
listener list under the lock, then iterate and call outside the lock.
This is related to the notifyListeners() improvements described in this issue.
> Improve the condition-based start/stop of Jobs
> ----------------------------------------------
>
> Key: SLING-13053
> URL: https://issues.apache.org/jira/browse/SLING-13053
> Project: Sling
> Issue Type: Improvement
> Components: Event
> Affects Versions: Event Impl 4.4.0
> Reporter: Joerg Hoh
> Priority: Major
>
> This is a followup of SLING-12743:
> * cleanups in the definition and the bind/unbind handling of the condition
> * fix the handling of the boolean parameter provided to
> ConfigurationChangeListener.configurationChanged() in the
> {{JobManagerConfiguration.notifyListeners()}} call. Instead of just providing
> {{caps != null}} it should also take the value of the JobProcessingCondition
> into account; right now this additional check is done in the QueueManager,
> but not in any other implementation (most notably not in the
> JobSchedulerImpl).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
