joerghoh commented on code in PR #73:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/73#discussion_r2942437979
##########
src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java:
##########
@@ -171,7 +175,7 @@ private RequestLog getLog(BundleContext bundleContext,
String output, int output
return new FileRequestLog(file);
} catch (IOException ioe) {
- // TODO: log
+ LOGGER.error("Failed to create file request log at '{}'",
file.getAbsolutePath(), ioe);
Review Comment:
```suggestion
LOGGER.error("Failed to create request log file at
'{}'", file.getAbsolutePath(), ioe);
```
That would feel a bit more natural for me, but this is just a really tiny
nitpick :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
