subiron commented on code in PR #85:
URL:
https://github.com/apache/sling-org-apache-sling-models-impl/pull/85#discussion_r2990893831
##########
src/main/java/org/apache/sling/models/impl/ModelPackageBundleListener.java:
##########
@@ -200,6 +200,13 @@ private void analyzeClass(Bundle bundle, String className,
List<ServiceRegistrat
bundle.getSymbolicName(),
e.getLocalizedMessage(),
e);
+ } catch (LinkageError e) {
+ log.error(
Review Comment:
Hi, thanks for your feedback.
I was actually wondering, “what kind of error should cause the processing of
the remaining models to be suspended”? In my opinion, there isn’t such a case,
but anything related to a `LinkageError` should catch the developer’s
attention, which is why I reported it as a bug.
I implemented the suggested changes because the error concerns only a
missing interface—but I’m still wondering what would be a better solution in
most cases
Translated with DeepL.com (free version)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
