Copilot commented on code in PR #77:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/77#discussion_r3009889304
##########
pom.xml:
##########
@@ -50,6 +50,7 @@
<properties>
<site.jira.version.id>12314252</site.jira.version.id>
<sling.java.version>8</sling.java.version>
+ <bnd.baseline.skip>true</bnd.baseline.skip>
Review Comment:
`bnd.baseline.skip` is set to `true`, which disables BND baseline checks for
this module. For an API artifact this removes an important safeguard against
unintended breaking changes; consider leaving baseline enabled (remove this
property) or scoping the skip to a dedicated profile (e.g., only for local
builds) with a short rationale so releases/CI still run baseline.
```suggestion
```
##########
README.md:
##########
@@ -5,6 +5,7 @@
# Apache Sling API
This module is part of the [Apache Sling](https://sling.apache.org) project.
+<!-- validation marker ut-r3-a -->
Review Comment:
The PR description says it "adds initial project files: README.md and
pom.xml", but the diff only tweaks existing files (baseline property,
dependency version management, and a README marker). Please update the PR
description to reflect the actual intent/scope so reviewers know why baseline
is being skipped and versions are being removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
