[
https://issues.apache.org/jira/browse/SLING-13233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18087073#comment-18087073
]
Roy Teeuwen commented on SLING-13233:
-------------------------------------
[~rombert] could you give an example for the "dynamically add projects that
are built in the reactor"?
There are multiple issues with the current way of working to make everything
work automatically without defining hardcoded paths.
The converter add's the output of the content package in
target/cp-conversion/fm.out/project.json.
But it also adds a set of synthetic packages / bundles in
target/cp-conversion/* => This means we can't easily detect it in the reactor.
I've been trying to build things around this, but haven't found a clean way yet
without making hard couplings between the converter / feature aggregator /
launcher plugins.
If you want to see what the final result would look like that I have right now:
https://github.com/apache/sling-whiteboard/compare/SLING-13233?expand=1#diff-6c959e0d65425232deeb38adfbc7d45ab628044791115281dc7db6ec4ecb1e15R57
(The additionalRepositoryUrl in the feature-launcher-maven-plugin is not
developed yet and is not a hard requirement, it's just to keep the converter
from pushing things to ~/.m2 to then use it in the launcher instead use the
reactor)
Go ahead and give feedback on what could be improved / changed in the
configurations and then we can more easily work from there.
> Multi-feature aggregation: add <featureFiles>, <features>,
> <osgiBsnCollisionDetection>, <artifactClashOverrides>
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SLING-13233
> URL: https://issues.apache.org/jira/browse/SLING-13233
> Project: Sling
> Issue Type: New Feature
> Affects Versions: Feature Launcher Maven Plugin 1.0.4
> Reporter: Roy Teeuwen
> Assignee: Roy Teeuwen
> Priority: Major
> Fix For: Feature Launcher Maven Plugin 1.0.6
>
>
> The <launch> element currently accepts exactly one of <feature> (Maven
> coordinates) or <featureFile> (local path), validated as mutually exclusive.
> This forces users who want to aggregate (e.g. Sling Starter + a downstream
> feature, or a base feature + tweaks) to either:
> * Pre-merge externally with a script that calls FeatureBuilder.assemble
> themselves, then point <featureFile> at the result, or
> * Skip the plugin entirely and shell out to the launcher tar.gz with their
> own arg construction.
> Both lose the plugin's start/stop lifecycle, attached-artifacts dir,
> port/repo plumbing, and JAVA_HOME fallback.
> This feature is meant to add all the capabilities that the CLI already
> supports (add <featureFiles>, <features>, <osgiBsnCollisionDetection>,
> <artifactClashOverrides>)
> Backward compatibility: The only meaningful semantic change: combining
> <feature> and <featureFile> was previously rejected at validation; now it's
> accepted as a two-feature aggregation. Existing single-feature configurations
> continue to work unchanged. The new fields are all optional with empty-list /
> false defaults.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
