royteeuwen commented on code in PR #33:
URL:
https://github.com/apache/sling-org-apache-sling-commons-log/pull/33#discussion_r3383581883
##########
src/main/java/org/apache/sling/commons/log/logback/store/package-info.java:
##########
@@ -23,7 +23,7 @@
* <p>The API is intentionally decoupled from slf4j and logback to prevent
binding to those APIs
* directly, which hinders evolution and is problematic when upgrading
dependency versions.</p>
*/
-@Version("1.0.0")
+@Version("2.0.0")
Review Comment:
@rombert Updated to 1.1.0 by adding a constructor for when it's still 7
params, can we live with that?
##########
src/main/java/org/apache/sling/commons/log/logback/store/package-info.java:
##########
@@ -23,7 +23,7 @@
* <p>The API is intentionally decoupled from slf4j and logback to prevent
binding to those APIs
* directly, which hinders evolution and is problematic when upgrading
dependency versions.</p>
*/
-@Version("1.0.0")
+@Version("2.0.0")
Review Comment:
@rombert Updated to 1.1.0 by adding a constructor for when it's still 7
params, can we live with that? If not, give other suggestions :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
