jsedding commented on code in PR #80:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/80#discussion_r3466261551
##########
src/main/java/org/apache/sling/engine/impl/helper/SlingFilterConfig.java:
##########
@@ -35,7 +35,7 @@
public class SlingFilterConfig implements FilterConfig {
/** The list of property names checked by {@link
#getName(ServiceReference)} */
- private static final String[] NAME_PROPERTIES = {"sling.core.servletName",
COMPONENT_NAME, SERVICE_PID, SERVICE_ID};
+ private static final String[] NAME_PROPERTIES = {"sling.core.servletName",
SERVICE_PID, COMPONENT_NAME, SERVICE_ID};
Review Comment:
Good point. I don't know.
How about renaming
`org.apache.sling.engine.impl.helper.SlingFilterConfig#getName` to
`#getMBeanName` (afaics it is only used for this purpose) and using
[`ObjectName#quote`](https://docs.oracle.com/javase/8/docs/api/javax/management/ObjectName.html#quote-java.lang.String-)
to make sure the string conforms to whatever an MBean name requires?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
