joerghoh commented on PR #54: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/54#issuecomment-5058161362
I am a bit unsure about this PR. Let's ignore all the whitespace changes for now, which inflate the size of the PR with no real reason. It tries to solve the problem of mismatch stubbing, a (potential?) problem we have in the unittests. It explicitly stubs the "non-provided" keys (with a return value of ``null``), so in that case the code actually ``getProperty(unstubedKey)`` returns ``null`` instead a ``null`` which any non-stubbed value would return. So I doubt that it's providing a real value, and I suggest to close it. Any opinion on that? (There 2 other PRs like this available, so I would treat them the same way.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
