raducotescu commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-js-provider/pull/12#issuecomment-5494046495
@pnvwrk, thanks for the fix. It seems to address your requirement without breaking any tests. Tiny nitpick: I think these tests would be better suited by a mocked repository setup (https://sling.apache.org/documentation/development/sling-mock.html), but I won't block the merge based on that. I have validated your changes by running the full IT suite from https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing (https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/tree/ba074339617ed2ceb246eeeac25a43c75deaf491). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
