kwin commented on code in PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-commons-crypto/pull/11#discussion_r4000537507
##########
src/main/java/org/apache/sling/commons/crypto/jca/internal/JcaPbeCryptoServiceConfiguration.java:
##########
@@ -73,6 +73,13 @@
)
String securityProviderName() default "SunJCE";
+ @AttributeDefinition(
+ name = "Security Provider Target",
+ description = "Filter expression to target a Security Provider
(usually by name with a pattern like
\"(provider.name=<securityProviderName>)\"). Useful to defer loading of the
service until the custom Security Provider bundle is available and properly
registered.",
+ required = false
Review Comment:
Should we provide a default value leveraging
https://github.com/apache/felix-dev/blob/master/configadmin-plugins/interpolation/README.md#interpolating-configuration-properties-self-references?
Is it fine to always require ConfigAdmin interpolation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
