kwin commented on code in PR #60:
URL: https://github.com/apache/sling-ide-tooling/pull/60#discussion_r4002949454
##########
shared/parent/pom.xml:
##########
@@ -148,7 +148,7 @@ Bundle-ActivationPolicy: lazy
<properties>
<sling.java.version>11</sling.java.version>
- <minimalJavaBuildVersion>17</minimalJavaBuildVersion><!-- Tycho
requires Java 17 -->
+ <minimalJavaBuildVersion>21</minimalJavaBuildVersion><!-- Tycho
5.x requires Java 21 -->
Review Comment:
Probably a wrong comment as IMHO the shared modules doesn't leverage Tycho
at all. Not sure we really need to bump the required Java version for this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
