rombert commented on code in PR #91:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/91#discussion_r4072375247
##########
src/main/java/org/apache/sling/engine/impl/log/CustomLogFormat.java:
##########
@@ -547,7 +547,7 @@ public ThreadParameter(String parParam) {
}
protected String getValue(RequestLoggerRequest request) {
- return Thread.currentThread().getName();
+ return escape(Thread.currentThread().getName());
Review Comment:
Could we add a regression test for the `%P`/`ThreadParameter` case as well?
This is one of the four directives explicitly covered by SLING-13360, but the
current tests exercise only request parameters, content paths, and remote hosts.
The missing case also leaves SonarQube at 75% coverage on new code, below
the 80% quality gate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
