anchela commented on code in PR #29:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/29#discussion_r4104730155
##########
src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java:
##########
@@ -992,6 +1007,7 @@ private boolean handleLoginFailure(
} else if (reason instanceof LoginException) {
log.info("handleLoginFailure: Unable to authenticate {}: {}",
user, reason.getMessage());
if (isAnonAllowed(request)
+ &&
request.getAttribute(REQUEST_ATTRIBUTE_ANONYMOUS_RESOLVER_ATTEMPTED) == null
Review Comment:
while this works it looks a bit strange. if someone would set the
REQUEST_ATTRIBUTE_ANONYMOUS_RESOLVER_ATTEMPTED to Boolean.FALSE it would also
pass because the object is not null but still it was slightly counter
intuitive. it's not a problem today but something that may end up being either
broken or not properly understood (or leading to misunderstanding) in the
future.
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
