[ 
https://issues.apache.org/jira/browse/SLING-13369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18124500#comment-18124500
 ] 

Konrad Windszus edited comment on SLING-13369 at 10/7/26 1:08 PM:
------------------------------------------------------------------

There is already an analyzer for package-dependencies at 
https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/master/src/main/java/org/apache/sling/feature/analyser/task/impl/CheckContentPackagesDependencies.java
 however this only checks those packages referenced in the feature model (i.e. 
the immutable ones).


was (Author: kwin):
There is already an analyzer for package-dependencies at 
https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/master/src/main/java/org/apache/sling/feature/analyser/task/impl/CheckContentPackagesDependencies.java.

> feature-cpconverter: Restrict and validate package dependencies of generated 
> mutable packages
> ---------------------------------------------------------------------------------------------
>
>                 Key: SLING-13369
>                 URL: https://issues.apache.org/jira/browse/SLING-13369
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content-Package to Feature Model Converter
>            Reporter: Konrad Windszus
>            Priority: Major
>
> Currently a non resolvable mutable content package dependency is just passed 
> on as is into the resulting package. Only those package dependencies are 
> mapped which are pointing to known mutable package ids (in 
> [https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/e2dc780ec226b38748d71b68b9872e9fa221adcc/src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java#L518).]
> In addition there should be:
>  * Removal of dependencies towards immutable package ids (as those packages 
> are dissolved)
>  * Validation of remaining dependency package ids so that only those 
> contained in the passed packages are allowed. Violations should lead to 
> exceptions.
>  * Also the version ranges within dependencies needs to be adjusted as cp2fm 
> packages have {{-cp2fm-converted}} suffix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to