bkkothari2255 commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-feature/pull/38#issuecomment-6790435075
> I dont see changes to the DefaultArtifactHandler in the PR Hi @cziegeler `DefaultArtifactHandler` is an internal private static class defined inside [ArtifactManager.java (around line 388)](https://github.com/bkkothari2255/sling-org-apache-sling-feature/blob/SLING-13376-diagnostics/src/main/java/org/apache/sling/feature/io/artifacts/ArtifactManager.java#L388) The changes to it are included within `ArtifactManager.java` in the PR diff (specifically lines 427–526), where - `DefaultArtifactHandler` implements the `new ArtifactProvider.getArtifactFile(...)` method. - `downloadRemoteArtifact(...)` captures and reports the per-repository HTTP response codes (e.g., 404, 401) and connection failures Please let me know if you’d prefer `DefaultArtifactHandler` to be extracted into its own package-private class file or if keeping it as an inner class inside `ArtifactManager` is good with you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
