cziegeler commented on code in PR #106:
URL:
https://github.com/apache/sling-org-apache-sling-engine/pull/106#discussion_r4537494656
##########
src/main/java/org/apache/sling/engine/impl/DefaultErrorHandler.java:
##########
@@ -48,14 +54,31 @@ public class DefaultErrorHandler implements
JakartaErrorHandler {
/** default log */
private final Logger log = LoggerFactory.getLogger(getClass());
+ // TODO - move this to API
+ private static final String HTML_CONTENT_TYPE = "text/html";
+
+ private static final String ALL_CONTENT_TYPES = "*/*";
+
+ // TODO - move this to API
+ static final String NON_HTML = "nonhtml";
+
/** Use this if not null, and if that fails output a report about that
failure */
private volatile JakartaErrorHandler delegate;
+ /** Use this if not null for non html responses */
+ private volatile JakartaErrorHandler nonHtmlDelegate;
+
private volatile JakartaErrorHandler errorHandler;
private volatile JakartaErrorHandler jakartaErrorHandler;
private volatile ServiceReference<?> errorHandlerRef;
private volatile ServiceReference<?> jakartaErrorHandlerRef;
+ private final Map<ServiceReference<JakartaErrorHandler>,
JakartaErrorHandler> jakartaErrorHandlers =
+ new TreeMap<>(Comparator.reverseOrder());
Review Comment:
Reverse order is correct, highest ranking wins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]