joerghoh commented on code in PR #78:
URL:
https://github.com/apache/sling-org-apache-sling-distribution-core/pull/78#discussion_r4549688228
##########
src/main/java/org/apache/sling/distribution/queue/impl/resource/ActiveResourceQueue.java:
##########
@@ -48,6 +48,15 @@ public ActiveResourceQueue(
super(resolverFactory, serviceName, queueName, rootPath);
}
+ public ActiveResourceQueue(
Review Comment:
Wouldn't it make sense to let the other constructor invoke this constructor
with a default value for ``useExactQueueLength``?
##########
src/main/java/org/apache/sling/distribution/queue/impl/resource/ResourceQueueProvider.java:
##########
@@ -65,6 +66,17 @@ public ResourceQueueProvider(
String agentName,
Scheduler scheduler,
boolean isActive) {
+ this(context, resolverFactory, serviceName, agentName, scheduler,
isActive, false);
Review Comment:
Why is this constructor directly invoking the parent c'tor, while the other
constructor works completely differently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]