Joscorbe commented on code in PR #62:
URL:
https://github.com/apache/sling-org-apache-sling-event/pull/62#discussion_r4568633649
##########
src/main/java/org/apache/sling/event/impl/jobs/JobManagerImpl.java:
##########
@@ -618,6 +640,37 @@ private Job addJobInternal(
return null;
}
+ /**
+ * Diagnose the routing decision before persistence, without exposing
potentially sensitive job
+ * properties.
+ */
+ private void logUnassignedJob(final String jobTopic, final String
queueName, final TopologyCapabilities caps) {
+ final long now = this.clock.millis();
+ // Log at max once per 5 minute interval and per topic
Review Comment:
@joerghoh could we maybe add the reason too (topic + reason)? My concern is,
we get a log message due to reason A, and others would log reason B but it get
silenced.
It's probably too edge case, but we can avoid it easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]