+1 (non binding) Based on my experience, a ResourceDecorator almost never applies globally to all resources all the time, but is very often based on request-dependent information (such as parameters).
Cheers, Alex Am 13.02.2012 um 11:05 schrieb Felix Meschberger: > > Hi > > Am 11.02.2012 um 02:19 schrieb Justin Edelson: > >> As described here: https://issues.apache.org/jira/browse/SLING-2411, we >> do not currently have a way of enforcing that ResourceResolver clients invoke >> resolve(HttpServletRequest, String) when they are doing a resolve >> inside a request >> context. The net effect of this is that implementors of ResourceDecorator >> have >> inconsistent results. >> >> I've uploaded a strawman patch to >> https://issues.apache.org/jira/browse/SLING-2411 to >> illustrate how this might be solved using a ThreadLocal. However, I >> personally feel >> like we should just go ahead and deprecate this method and I'd like to >> call a vote for it. >> >> Please vote: >> [ ] +1 - deprecate ResourceDecorator.decorate(Resource, HttpServletRequest) >> [ ] 0 >> [ ] -1 - don't deprecate >> >> Note - if you vote -1, please provide an alternative. It could be the >> strawman, it could be >> something else, but I'd really like to see this fixed. > > +1 to deprecate. > > Regards > Felix > >> >> Thanks >> Justin > -- Alexander Klimetschek Developer // Adobe (Day) // Berlin - Basel
