[
https://issues.apache.org/jira/browse/SLING-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292472#comment-13292472
]
Eric Norman commented on SLING-2504:
------------------------------------
Thanks for the patch.
I have done a quick review and have some initial thoughts for your
consideration.
1. The org.apache.sling.auth.selector bundle may not always be installed. In
that case, you would want the custom-login-form to remain as it was before
attached to the org.apache.sling.auth.form bundle. So maybe it would make
sense to have a second sample for a custom login form attached to the
o.a.s.auth.selector bundle?
2. The login.html file from org.apache.sling.auth.form would still be used
depending on how the user navigates to the login page so it should not be
deleted. For example, if the user navigates directly to
/system/sling/form/login vs. /system/sling/selector/login
Does that make sense?
> custom-login-form bundle is not working as expected
> ---------------------------------------------------
>
> Key: SLING-2504
> URL: https://issues.apache.org/jira/browse/SLING-2504
> Project: Sling
> Issue Type: Bug
> Components: Samples
> Affects Versions: Form Based Authentication 1.0.0
> Reporter: Dragos Dascalita Haut
> Labels: patch, samples
> Attachments: fixing_custom_login_form_sample.patch
>
>
> The custom-login-form doesn't affect the actual login UI.
> The bundle registers as a fragment for org.apache.sling.auth.form, while
> SelectorFormServlet is in org.apache.sling.auth.selector.
> The custom-login-form sample should register as a fragment for
> org.apache.sling.auth.selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
