Hi all,
I just had a quick look at the current (Rev. 1366999) of the Resource API
(o.a.s.api.resource) and have some remarks on that:
* What is the behaviour of the deprecated PersistableValueMap ? Will
the save method still persist changes (Session.save() in JCR speak) ?
* What is the spec of the exceptions declared on the new ResourceResolver
methods (delete, addChild) ?
* The new ResourceResolver methods commit and revert are spec-ed without
exceptions (except PE on commit). Could there be exceptions thrown like
UnsupportedOperationException ?
* I think the ResourceResolver.addChild method should be caled "create"
and the syntax of the "name" argument be defined: is this a simple
name (without slash characters) or a relative path ? If relative path,
what about missing intermediate nodes ?
* The JavaDoc of ResourceProviderFactory methods should be fixed (they
look like copied from ResourceResolverFactory)
* On QueriableResourceProvider:
- I think null is a valid result indicating non-support for
the query language. No results would probably require an empty
iterator.
- Thus unsupported query languages just cause the methods to
to return null.
- A service property should be added (String or String[]) indicating
the query languages supported by the service. For
ResourceProviderFactory provided QueriableResourceProvider
instances this property must be defined on the
ResourceProviderFactory service.
WDYT ?
Regards
Felix
