[ 
https://issues.apache.org/jira/browse/SLING-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486732#comment-13486732
 ] 

Carsten Ziegeler commented on SLING-2240:
-----------------------------------------

I haven't looked at the classes so far, having done so I think RequestProperty 
should not be exported, it really seems more like an internal class.
JSONResponse is already exported.

So we're back to DateParser - if we increase the package version (which we have 
to if we add something to the package) then like Felix explained this breaks 
implementor bundles.
If we start with this fact, it means we shouldn't increase the package version 
which means we shouldn't add DateParser to that package.

We have three options then:
1) leave everything as is
2) Create a new public package in the post servlet bundle and move the class 
there
3) Add the class to another common bundle - whatever this is

I don't think we have a good place for 3) atm, so we either go with 2) or 1)

                
> move org.apache.sling.servlets.post.impl.helper.DateParser to commons
> ---------------------------------------------------------------------
>
>                 Key: SLING-2240
>                 URL: https://issues.apache.org/jira/browse/SLING-2240
>             Project: Sling
>          Issue Type: Wish
>          Components: Commons
>    Affects Versions: Servlets Post 2.1.0
>            Reporter: Ben Peter
>            Assignee: Ian Boston
>         Attachments: SLING-2240.patch
>
>
> DateParser is a nice utility and comes in handy in a lot of cases. 
> As such, it would be great to have it in a place where it is part of an 
> exported package instead of being locked in in the private 
> org.apache.sling.servlets.post.impl.helper

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to