[
https://issues.apache.org/jira/browse/SLING-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491392#comment-13491392
]
Julian Sedding commented on SLING-2641:
---------------------------------------
The patch looks good, except some minor nitpicks:
* the patch includes changes to the QueriableResourceProvider interface
* javadoc for Resource#getChildren states "Returns an iterator ...", it should
be "Returns an iterable ..."
* javadoc for ResourceResolver#getChildren states "Returns an
<code>Iterator</code> ...", it should be "Returns an <code>Iterable</code> ..."
> Make listChildren() Iterable
> ----------------------------
>
> Key: SLING-2641
> URL: https://issues.apache.org/jira/browse/SLING-2641
> Project: Sling
> Issue Type: Improvement
> Components: API, General, ResourceResolver, Testing
> Affects Versions: API 2.2.4
> Reporter: Dan Klco
> Assignee: Carsten Ziegeler
> Labels: features, noob, patch
> Attachments: iterable-patch.txt, SLING-2641-Resource-Iterator.diff
>
>
> When you call Resource.listChildren() or resourceResolver.listChildren() it
> returns a Iterator<Resource>, this is fine if you want to just iterate
> through the results using old-style while loops, but if you want to use
> enhanced loops, you are out of luck.
> I'm proposing adding an interface to return from these methods which extends
> both Iterator<Resource> and Iterable<Resource>. This will allow for using
> enhanced loops with the results of listChildren().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
