[
https://issues.apache.org/jira/browse/SLING-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526201#comment-13526201
]
Carsten Ziegeler commented on SLING-2695:
-----------------------------------------
The current way of logging has the advantage that all log messages for
resolving a script get into the same category regardless which implementation
class is logging. This makes finding these log messages a little bit easier.
While the logger in the resolver is public and therefore global it's not
accessible outside the bundle.
So in the end it's a matter of taste I guess
For the additional log message, this is already logged in
AbstractResouceCollector.isPathAllowed
> SlingServletResolver Logging
> ----------------------------
>
> Key: SLING-2695
> URL: https://issues.apache.org/jira/browse/SLING-2695
> Project: Sling
> Issue Type: Improvement
> Components: Servlets
> Affects Versions: Servlets Resolver 2.2.0
> Reporter: Dan Klco
> Priority: Minor
> Labels: patch
> Attachments: SLING-2695.diff
>
>
> There are two odd things (to me at least) about the Sling Servlet Resolver.
> First, the logger for this class is public static final, which means it is
> effectively a global variable. It is actually referenced outside the class
> in the AbstractResourceCollector.
> Second, when the Sling Servlet Resolver is going to resolve a request and if
> finds that the request path is not in the servletresolver.paths set of
> allowed paths, it sends a log message to the getRequestProgressTracker, but I
> would think it should log at least an info message to the logs, letting the
> developer know that the script is not going to be executed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
