[ 
https://issues.apache.org/jira/browse/SLING-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562481#comment-13562481
 ] 

Carsten Ziegeler commented on SLING-2714:
-----------------------------------------

Not sure if wrapping is really needed, it seems that at least newer slf4j 
versions support array types, however I'm pretty sure that older didn't. As the 
additional check doesn't hurt, I guess we can leave it this way.
I changed the logger to be non static anymore, thanks for pointing out!


                
> Wrap LOGGER.debug calls in ResourceProviderEntry
> ------------------------------------------------
>
>                 Key: SLING-2714
>                 URL: https://issues.apache.org/jira/browse/SLING-2714
>             Project: Sling
>          Issue Type: Improvement
>          Components: ResourceResolver
>    Affects Versions: Resource Resolver 1.0.2
>            Reporter: Alexander Muthmann
>            Assignee: Carsten Ziegeler
>             Fix For: Resource Resolver 1.0.4
>
>         Attachments: SLING-2714.diff
>
>
> In ResourceProviderEntry.java there are multiple LOGGER.debug calls which 
> access Arrays.toString(). This causes the Arrays.toString() call to be 
> executed no matter which Logger-Level is set.
> Those calls should be wrapped in a LOGGER.isDebugEnabled(). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to