[ 
https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-2727:
---------------------------------

    Description: 
1. I have modified PerformanceRunner to be able to run tests provided through a 
factory method annotated with @PerformanceTestFactory, when used with 
@PerformanceTestSuites. The method can be used (this is optional) on a "test 
case" object that is added to the ParameterizedTestList returned by the 
@PerformanceTestSuite method. If there is no @PerformanceTestFactory method, 
the behaviour stays the same as before. If a @PerformanceTestFactory exists, 
the PerformanceRunner adds all the test case instances returned by the factory 
to the testObjects list, instead of the test case itself. 
Optionally, the test cases can implement an IdentifiableTestCase interface, 
which gives the ability to have custom names for tests running on different 
instances.

2. Modified ReportLogger to log the test case name as well. Also, changed the 
method signatures so that it's clear what is being logged. This works with 
patch 1 to distinguish between different test case instances


The motivation behind this is that a suite can contain test cases that are 
different logically, but the test case should be able to be parameterized.

  was:
1. I have modified PerformanceRunner to be able to run tests provided through a 
factory method annotated with @PerformanceTestFactory. The method should return 
a scalar, an array or a list of objects which contain methods. annotated with 
the existent @PerformanceTest. Optionally, the class(es) returned by the 
factory method can implement an IdentifiableTestCase interface, which gives the 
ability to have custom names for tests running on different instances. The test 
collection is done statically, so this works with the existing 
@Before/AfterMethodInvocation, allowing to have different test setups at once.

2. Modified ReportLogger to log the test case name as well. Also, changed the 
method signatures so that it's clear what is being logged. This is important 
for patch 1 to distinguish between different test setups.

    
> Allow PerformanceRunner to run tests provided by a factory method
> -----------------------------------------------------------------
>
>                 Key: SLING-2727
>                 URL: https://issues.apache.org/jira/browse/SLING-2727
>             Project: Sling
>          Issue Type: Improvement
>          Components: Testing
>            Reporter: Andrei Dulvac
>            Priority: Minor
>              Labels: PatchAvailable
>         Attachments: performance_factory.patch, performance_reportlogger.patch
>
>
> 1. I have modified PerformanceRunner to be able to run tests provided through 
> a factory method annotated with @PerformanceTestFactory, when used with 
> @PerformanceTestSuites. The method can be used (this is optional) on a "test 
> case" object that is added to the ParameterizedTestList returned by the 
> @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, 
> the behaviour stays the same as before. If a @PerformanceTestFactory exists, 
> the PerformanceRunner adds all the test case instances returned by the 
> factory to the testObjects list, instead of the test case itself. 
> Optionally, the test cases can implement an IdentifiableTestCase interface, 
> which gives the ability to have custom names for tests running on different 
> instances.
> 2. Modified ReportLogger to log the test case name as well. Also, changed the 
> method signatures so that it's clear what is being logged. This works with 
> patch 1 to distinguish between different test case instances
> The motivation behind this is that a suite can contain test cases that are 
> different logically, but the test case should be able to be parameterized.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to